]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
grabHelper: Throw an error if the owner is not an actor
authorMarco Trevisan (Treviño) <mail@3v1n0.net>
Wed, 29 May 2019 19:43:27 +0000 (14:43 -0500)
committerMarco Trevisan (Treviño) <mail@3v1n0.net>
Wed, 29 May 2019 20:13:00 +0000 (15:13 -0500)
Starting from commit 7bb84dae, GrabHelper requires the owner to be an Actor as
we pass this to pushModal that assumes it to be as well.

So check that GrabHelper owner is an actor and throws an error if it is not the
case. This helps in tracking down issues such as gnome-shell-extensions!68

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/565

js/ui/grabHelper.js

index 4ba0b1b568bf896be7312365cb47db4a9940d465..50991501906edd0ddbb46bd92ba643eb940173bc 100644 (file)
@@ -43,6 +43,9 @@ function _popGrabHelper(grabHelper) {
 // call grab().
 var GrabHelper = class GrabHelper {
     constructor(owner, params) {
+        if (!(owner instanceof Clutter.Actor))
+            throw new Error('GrabHelper owner must be a Clutter.Actor');
+
         this._owner = owner;
         this._modalParams = params;